Skip to content

handshake in ssl_client.cpp #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 26, 2018
Merged

handshake in ssl_client.cpp #2044

merged 4 commits into from
Nov 26, 2018

Conversation

a-c-sreedhar-reddy
Copy link
Contributor

@a-c-sreedhar-reddy a-c-sreedhar-reddy commented Nov 10, 2018 •
edited
Loading

issue #2041

@a-c-sreedhar-reddy a-c-sreedhar-reddy changed the title issue #2041 handshake in ssl_client.cpp Nov 10, 2018
@lbernstone
Copy link
Contributor

You should use a #define value rather than a hardcoded timeout value.

@atanisoft
Copy link
Collaborator

Instead of a #define it would be even better to have this timeout value configured in sslclient_context so it can be adjusted by the library users code.

@me-no-dev
Copy link
Member

agreed with @atanisoft ! @a-c-sreedhar-reddy will you make the change?

@a-c-sreedhar-reddy
Copy link
Contributor Author

agreed with @atanisoft ! @a-c-sreedhar-reddy will you make the change?

@me-no-dev changes made.

@me-no-dev me-no-dev merged commit 46257c0 into espressif:master Nov 26, 2018
@me-no-dev
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanisoft atanisoft atanisoft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-c-sreedhar-reddy @lbernstone @atanisoft @me-no-dev